Skip to content

Add: Implement ACL check for /agentready assess command authorization#251

Merged
jeremyeder merged 1 commit intoambient-code:mainfrom
kami619:agentready-acl
Jan 15, 2026
Merged

Add: Implement ACL check for /agentready assess command authorization#251
jeremyeder merged 1 commit intoambient-code:mainfrom
kami619:agentready-acl

Conversation

@kami619
Copy link
Copy Markdown
Collaborator

@kami619 kami619 commented Jan 14, 2026

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test coverage improvement

Related Issues

Fixes #249
Relates to #247

Changes Made

ACL Configuration File — Created .github/agentready-acl.yml with:

  • Initial authorized user (jeremyeder)
  • Comments explaining usage

check-agentready-acl Job — Added to workflow with:

  • Handles workflow_dispatch (always authorized)
  • Handles comment events (checks ACL file)
  • Outputs is_authorized for dependent jobs
  • Uses explicit naming (check-agentready-acl)

assess Job — Updated to:

  • Depend on check-agentready-acl via needs: check-agentready-acl
  • Use condition: needs.check-agentready-acl.outputs.is_authorized == 'true'
  • Covers both manual triggers and authorized comment events

unauthorized Job — Updated to:

  • Depend on check-agentready-acl via needs: check-agentready-acl
  • Use condition checking is_authorized == 'false' and comment events only

Testing

I couldn't test this from my fork.

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Expected Workflow

Screenshot 2026-01-14 at 14 52 22

@jeremyeder
Copy link
Copy Markdown
Contributor

sure - you can add yourself to the list in a follow-up pr.

@jeremyeder jeremyeder merged commit f8deada into ambient-code:main Jan 15, 2026
1 of 2 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.22.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Configuration file-based ACL for /agentready assess command

2 participants