Skip to content

fix(frontend): correct GitHub callback path and add production ConfigMap patch #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markturansky merged 4 commits into from
Apr 23, 2026
Merged

fix(frontend): correct GitHub callback path and add production ConfigMap patch #1443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ced7016
Merge branch 'main' of https://github.com/ambient-code/platform
jsell-rh Apr 23, 2026
cf2133c
Merge branch 'main' of https://github.com/ambient-code/platform
jsell-rh Apr 23, 2026
644da6c
fix(frontend,ci): correct GitHub callback path and add to CI workflows
jsell-rh Apr 23, 2026
68814b8
Merge branch 'main' into fix/github-callback-path-and-configmap
mergify[bot] Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/components-build-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,7 @@ jobs:
run: |
oc set env deployment/frontend -n ambient-code -c frontend \
GITHUB_APP_SLUG="ambient-code-stage" \
GITHUB_CALLBACK_URL="https://ambient-code.apps.rosa.vteam-stage.7fpc.p3.openshiftapps.com/api/auth/github/user/callback" \
FEEDBACK_URL="https://forms.gle/7XiWrvo6No922DUz6"

- name: Update operator environment variables
Expand Down Expand Up @@ -477,6 +478,7 @@ jobs:
run: |
oc set env deployment/frontend -n ambient-code -c frontend \
GITHUB_APP_SLUG="ambient-code-stage" \
GITHUB_CALLBACK_URL="https://ambient-code.apps.rosa.vteam-stage.7fpc.p3.openshiftapps.com/api/auth/github/user/callback" \
FEEDBACK_URL="https://forms.gle/7XiWrvo6No922DUz6"

- name: Update operator environment variables
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/prod-release-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,7 @@ jobs:
run: |
oc set env deployment/frontend -n ambient-code -c frontend \
GITHUB_APP_SLUG="ambient-code" \
GITHUB_CALLBACK_URL="https://ambient-code.apps.rosa.vteam-uat.0ksl.p3.openshiftapps.com/api/auth/github/user/callback" \
FEEDBACK_URL="https://forms.gle/7XiWrvo6No922DUz6"

- name: Update operator environment variables
Expand Down
2 changes: 1 addition & 1 deletion components/frontend/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ In production, put an OAuth/ingress proxy in front of the app to set these heade
- `GITHUB_APP_SLUG` (required for GitHub integration)
- The slug of the GitHub App (e.g. `ambient-code`). Without this, the Connect button on the Integrations page is disabled.
- `GITHUB_CALLBACK_URL` (optional)
- Explicit callback URL for GitHub App OAuth. Used when multiple clusters share one GitHub App. Falls back to `<current origin>/integrations/github/setup`. Must be registered as a callback URL in the GitHub App settings.
- Explicit callback URL for GitHub App OAuth. Used when multiple clusters share one GitHub App. Falls back to `<current origin>/api/auth/github/user/callback`. Must be registered as a callback URL in the GitHub App settings. Set per-cluster via CI workflow (`oc set env`).
- Optional dev helpers: `OC_USER`, `OC_EMAIL`, `OC_TOKEN`, `ENABLE_OC_WHOAMI=1`

You can also put these in a `.env.local` file in this folder:
Expand Down
2 changes: 1 addition & 1 deletion components/frontend/src/components/github-connection-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export function GitHubConnectionCard({ appSlug, githubCallbackUrl, showManageBut

const handleConnect = () => {
if (!appSlug) return
const callbackUrl = githubCallbackUrl || `${window.location.origin}/integrations/github/setup`
const callbackUrl = githubCallbackUrl || `${window.location.origin}/api/auth/github/user/callback`
const url = `https://github.com/apps/${appSlug}/installations/new?redirect_uri=${encodeURIComponent(callbackUrl)}`
window.location.href = url
}
Expand Down