spec: add markdown rendering specs#1476
Draft
jsell-rh wants to merge 5 commits intoambient-code:mainfrom
Draft
Conversation
Three-part spec for fixing markdown rendering in message.tsx and tool-message.tsx. Covers core layout bugs (inline wrapper, font-mono, paragraph spacing), GFM table rendering with shared component overrides, and remaining GFM elements (blockquote, hr, img, h4-h6). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for cheerful-kitten-f556a0 canceled.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replace bug-fix framing in Overview and Input sections with desired-state descriptions of the expected rendering behavior. Implementation details (what changes) remain in plan.md files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
012a-markdown-layout-bugs → 012a-markdown-prose-rendering 012b-markdown-tables → 012b-markdown-table-rendering 012c-markdown-gfm-elements → 012c-markdown-gfm-rendering Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Accidentally included pre-existing mode changes (100644 → 100755) on 001, 010, and 011 specs in the previous rename commit. No content changed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jsell-rh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat/markdown-layout-bugs): Fixes three structural bugs inmessage.tsx—className="inline"wrapper collapsing block content,font-monoapplied to all prose, and near-zero paragraph margin (mb-[0.2rem]). Also addsstrong,em,deloverrides and harmonizes list spacing. Prerequisite for 012b and 012c.feat/markdown-tables): Adds GFM table rendering via six component overrides (table,thead,tbody,tr,th,td). Introducessrc/lib/markdown-components.tswith a sharedsharedMarkdownComponentsexport used by bothmessage.tsxandtool-message.tsx. Requires movingmarkdownComponentsintool-message.tsxto module level.feat/markdown-gfm-elements): Addsblockquote(P1),hrandimg(P2), andh4–h6(P3, gated on team decision) overrides to the shared constant from 012b.Test plan
npx vitest runpasses; manual streaming cursor stays inline;font-monogone from prose---produces themed separator; wide images don't overflow🤖 Generated with Claude Code