Yuchen Xie's Code Review#1- Final Project#5
Open
Yuchen112211 wants to merge 1 commit intoamdacccache:mainfrom
Open
Yuchen Xie's Code Review#1- Final Project#5Yuchen112211 wants to merge 1 commit intoamdacccache:mainfrom
Yuchen112211 wants to merge 1 commit intoamdacccache:mainfrom
Conversation
Line 45: I used the same trick to pass the accessibility test lmao, seems like react has this bug that aria-label attribute cannot be added to the correct element. Good job fixing this by adding to label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 45: I used the same trick to pass the accessibility test lmao, seems like react has this bug that aria-label attribute cannot be added to the correct element. Good job fixing this by adding to label.