Skip to content

Rewrite Game List in SwiftUI#40

Draft
amiantos wants to merge 4 commits intomasterfrom
gamelist-swiftui
Draft

Rewrite Game List in SwiftUI#40
amiantos wants to merge 4 commits intomasterfrom
gamelist-swiftui

Conversation

@amiantos
Copy link
Owner

@amiantos amiantos commented Apr 8, 2023

Kinda just for fun

@amiantos amiantos marked this pull request as draft April 8, 2023 23:20
Comment on lines +30 to +33
Text(game.about ?? "")
.font(.subheadline)
.frame(maxWidth: .infinity, alignment: .leading)
.padding(EdgeInsets(top: 0, leading: 22, bottom: 8, trailing: 22))
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can help with text getting truncated:

https://stackoverflow.com/questions/56507497/views-compressed-by-other-views-in-swiftui-vstack-and-list/57677746#57677746

Text(content)
                .fixedSize(horizontal: false, vertical: true)
                .frame(maxWidth: .infinity, alignment: .leading)
                .font(.subheadline)
                .padding(EdgeInsets(top: 0, leading: 22, bottom: 8, trailing: 22))

@amiantos
Copy link
Owner Author

Unfortunately because we want to support iOS 13& 14 I have a feeling SwiftUI is a no go for this project for a while.

@amiantos
Copy link
Owner Author

Unfortunately because we want to support iOS 13& 14 I have a feeling SwiftUI is a no go for this project for a while.

Backing up a little, iOS 13 support doesn't mean no Swift UI, it just means not as great iOS 13-era SwiftUI. So using SwiftUI is still an option... just more complicated now probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant