feat: add preference to show/hide widget while recording#67
feat: add preference to show/hide widget while recording#67Shahor wants to merge 1 commit intoamicalhq:mainfrom
Conversation
📝 WalkthroughWalkthroughAdded a new boolean preference Changes
Sequence Diagram(s)sequenceDiagram
participant UI as "Renderer UI\n(Settings Page)"
participant TRPC as "trpc Router\n(API)"
participant Service as "Settings Service"
participant DB as "DB / App Settings"
participant App as "Main App\n(AppManager / Idle)"
UI->>TRPC: setPreferences({ showWidgetWhileActive })
TRPC->>Service: setPreferences(payload)
Service->>DB: persist preferences (showWidgetWhileActive)
Service-->>App: emit "preferences-changed" (showWidgetWhileActiveChanged: true)
App->>App: evaluate idle state
alt idle
App->>App: use showWidgetWhileInactive to set widget visibility
else active
App->>App: use showWidgetWhileActive to set widget visibility
end
App-->>UI: (optionally) update widget state / UI
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
52e4dd2 to
fffcd14
Compare
Adds a new "Show widget while active" toggle in preferences that allows users to control whether the recording widget is visible during active recording sessions. Previously the widget was always shown when recording. The changes add: - New showWidgetWhileActive preference with UI toggle - Logic in app-manager.ts to conditionally show/hide widget based on recording state - Schema, settings service, and tRPC updates to support the new setting
fffcd14 to
0d8e769
Compare
|
Hey @Shahor If you can help me with the reproduction of the issue, and if just ensuring widget doesn't grab focus won't solve it, I should be able to better help out here. |
Adds a new "Show widget while active" toggle in preferences that allows
users to control whether the recording widget is visible during active
recording sessions. Previously the widget was always shown when recording.
The changes add:
Why
When using tiling window managers like Aerospace, the recording widget appearing can be
disruptive. These window managers automatically manage window focus and workspace
placement, so when the widget appears and takes focus, it can:
This preference allows users to hide the widget during active recording, avoiding these
focus-stealing issues while still being able to record.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.