Improve handling of non-zero ffmpeg responses#136
Open
xM8WVqaG wants to merge 1 commit intoamietn:masterfrom
Open
Improve handling of non-zero ffmpeg responses#136xM8WVqaG wants to merge 1 commit intoamietn:masterfrom
xM8WVqaG wants to merge 1 commit intoamietn:masterfrom
Conversation
Currently 'make_capture()' just drops the output from the ffmpeg CLI. By switching to 'subprocess.run()' it is possible to handle non-zero exit codes from the ffmpeg CLI. This prints out the full ffmpeg command, exit code and the response from ffmpeg which should be enough for a tech-savvy user to debug. Given this will nearly always be an issue with the ffmpeg installation or the file there isn't anything more vcsi can do in this situation. This is implemented as an exception so that when run with '--ignore-errors' the file can be skipped. Fixes: amietn#104 Fixes: amietn#103 Fixes: amietn#86 Fixes: amietn#82 Fixes: amietn#75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently 'make_capture()' just drops the output from the ffmpeg CLI.
By switching to 'subprocess.run()' it is possible to handle non-zero exit codes from the ffmpeg CLI. This prints out the full ffmpeg command, exit code and the response from ffmpeg which should be enough for a tech-savvy user to debug.
Given this will nearly always be an issue with the ffmpeg installation or the file there isn't anything more vcsi can do in this situation.
This is implemented as an exception so that when run with '--ignore-errors' the file can be skipped.
Fixes: #104
Fixes: #103
Fixes: #86
Fixes: #82
Fixes: #75