-
Notifications
You must be signed in to change notification settings - Fork 0
Feedback #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feedback
Are you sure you want to change the base?
Feedback #1
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Course goals/innovation: (10/10) reproduction and extension of a published machine learning model applied to Kepler data Technical challenge: (9/10) sophisticated use of production-grade neural network tools to prepare data and choose hyperparameters prior to assembly of a complex neural network. Implementation quality: (15/15) Two different approaches successfully implemented: both binary and multiclass. Code documentation/reproducibility: (11/15) more comments at function level explaining purposes and goals would make code clearer to read and easier to maintain. Writeup motivation: (10/10) clear summary of existing work with appropriate references to the relevant literature, along with good justification for the choice of model to reproduce. Clear description of model architecture. Writeup results: (28/30) Overall an exemplary presentation. However, more explanation of machine-learning specific terminology is important for presenting to domain-specific specialists. Loss curves, AUC scores and other performance metrics are critical to understand, but not necessarily widely known outside of the ML community, so their implications should be made explicit when reporting results. Writeup lessons learned/future: (10/10) Clear placement of results in context, particularly in the comparison with ExoMiner. Total: (93/100) Outstanding work! |
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
main
since the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.Subscribed: @beccaroskill