Merged
Conversation
Apply fixes from StyleCI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates amranidev/laracombee for modern Laravel versions and refreshes the package documentation.
It adds Laravel 10, 11, and 12 compatibility by updating Composer constraints and moving the test stack to the current Testbench/PHPUnit versions. It also removes older framework assumptions such as App\User and Illuminate\Foundation\Auth\User, replacing them with current Laravel conventions like App\Models\User and Authenticatable. The service provider was adjusted to merge config properly and register commands only in console contexts.
The test suite was also stabilized. Instead of relying on live Recombee API calls, tests now use a fake client so they run deterministically in CI and local development. PHPUnit configuration was updated for the current schema, and the suite passes cleanly.
Finally, the README was rewritten and polished to fix grammar, remove outdated setup instructions, and align the examples and configuration guidance with the current package behavior.
Key changes
Verification