Skip to content

Conversation

@sdzx1993
Copy link

...

h <- openFile fp ReadMode
hSetEncoding h utf8
hGetContents h

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File handle leak.

hClose h

Alternatively, maybe switching all Strings to hackage.haskell.org/package/text and use T.readFile

@amtal
Copy link
Owner

amtal commented Mar 26, 2020

A new language targeting CoreErlang + BEAM! Cool!

It looks like the PDF specification is very out of date. The main low-level specification is now core_parse.yrl and cerl.erl for high-level.

The Syntax.hs structures are missing many Ann annotations (#3) in addition to #{ K => V } maps. It may be time for a big compatibility break. Let me take a look...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants