Skip to content

Assignment#1

Open
FrancisGregori wants to merge 21 commits intoanadise:mainfrom
FrancisGregori:refactor/assignment
Open

Assignment#1
FrancisGregori wants to merge 21 commits intoanadise:mainfrom
FrancisGregori:refactor/assignment

Conversation

@FrancisGregori
Copy link

@FrancisGregori FrancisGregori commented Feb 25, 2023

Follow the PR with the completed assigned tasks.

Punctuating only two things here about the highlight task.

  • Instead of using useEffect, I preferred to make a hook that takes care of typing debounce and has a delay of 500ms before changing the highlight state.
  • Besides searching by client id, I left the option to search by name as well. I thought this approach was valid because we don't have the id on screen.

PS: if you want to test using the user ID, I added the ID value as id ta TR to facilitate access to this data.

And finally, in the description of commits, I like to use the default conventional commits, so if you have any questions about it, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant