fixed bug in python cmake binding#204
Open
dizcza wants to merge 1 commit intoanalogdevicesinc:masterfrom
Open
Conversation
Signed-off-by: dizcza <dizcza@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cmake version 3.4 wrongly identifies the python path. In particular, it picks system python rather than the local currently active (conda or virtualenv), resulting in an error - a rather untrivial case, made me think a lot to figure that out.
I haven't checked which CMake version fixes this, but 3.18 works fine.