remoteproc: adi: adding crc check for LDR headers #2912
+188
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artursartamonovsadi
requested review from
pamolloy,
UtsavAgarwalADI and
CalebEthridgeADI
drivers/remoteproc/adi_remoteproc.c
Outdated
| @@ -132,10 +138,10 @@ static struct adi_sharc_resource_table _rsc_table_template = { | |||
| }, | |||
| }; | |||
|
|
|||
| enum adi_rproc_rpmsg_state { | |||
There was a problem hiding this comment.
I think these changes require a separate commit since they dont really contribute to the feature.
Also, if RPMsg and remoteproc are sharing a common structure/flags/states, would it be a better idea to look at a common abstraction layer that just plugs into the two interfaces? if so, do we need these changes for now?
drivers/remoteproc/adi_remoteproc.c
Outdated
| } | ||
| if (ret) { | ||
| dev_err(rproc_data->dev, "Fail to request ICC IRQ\n"); | ||
| if (!rproc_data->adi_rsc_table) { |
pamolloy
reviewed
Aug 27, 2025
pamolloy
reviewed
Aug 27, 2025
|
In the future if you are linting a source file (e.g. fixing line length) and making functional changes it would be nice to separate them into different commits |
pamolloy
reviewed
Aug 27, 2025
pamolloy
reviewed
Aug 27, 2025
|
|
||
| rproc_data = (struct adi_rproc_data *)rproc->priv; |
There was a problem hiding this comment.
I assume this isn't a line length issue since the function header is longer?
pamolloy
reviewed
Aug 27, 2025
pamolloy
reviewed
Aug 27, 2025
pamolloy
reviewed
Aug 27, 2025
artursartamonovsadi
force-pushed
the
adsp-main-6.12-integrate-remoteproc-crc
branch
2 times, most recently
from
6248b01 to
2178c53
Compare
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com> Signed-off-by: Utsav Agarwal <Utsav.Agarwal@analog.com> Co-developed-by: Utsav Agarwal <Utsav.Agarwal@analog.com>
artursartamonovsadi
force-pushed
the
adsp-main-6.12-integrate-remoteproc-crc
branch
from
2178c53 to
8bfa5ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks checksum of LDR Section headers.
PR Type
PR Checklist