arm: dts: add missing I2C controllers for sc59x#82
Conversation
|
The commit also needs a See https://github.com/analogdevicesinc/u-boot/actions/runs/23550435921/job/68562607502?pr=82#step:7:37 |
|
When it is ready to be upstreamed please use https://docs.u-boot.org/en/latest/develop/patman.html#patman-patch-manager, it also runs additional checks |
jiez
force-pushed
the
67-i2c-nodes-missing-in-some-adsp-sc5xx-devicetrees
branch
from
df54059 to
9514587
Compare
|
|
||
| &i2c2 { | ||
| clocks = <&clk ADSP_SC598_CLK_CGU0_SCLK0>; | ||
| status = "okay"; |
There was a problem hiding this comment.
I think this should be in sc598-som-revD.dtsi and sc598-som-revE.dtsi which include SPI flash nodes o this bus
There was a problem hiding this comment.
Just wanted to save one line of code. I will move it to these two files.
There was a problem hiding this comment.
Once you do that you can post it to the mailing list. Then add the Lore link to the commit message so we can merge it here.
There was a problem hiding this comment.
I have to wait for this patch getting merged first
https://lists.denx.de/pipermail/u-boot/2026-March/613425.html
There was a problem hiding this comment.
Just make it clear that your patch depends on that in the cover letter. And I'd recommend using lore for all mailing lists rather than the project specific sites.
jiez
force-pushed
the
67-i2c-nodes-missing-in-some-adsp-sc5xx-devicetrees
branch
from
9514587 to
dca4b12
Compare
|
The link of patch submitted to upstream: https://lore.kernel.org/u-boot/20260402171330.165754-2-jzhang918@gmail.com/ |
jiez
force-pushed
the
67-i2c-nodes-missing-in-some-adsp-sc5xx-devicetrees
branch
from
dca4b12 to
65f761d
Compare
sc59x processors have 6 I2C controllers, but their devicetrees currently have only 3. The length of its register block should be 0x100 instead of 0x1000. All I2C nodes should be disabled in sc5xx.dtsi. They can be enabled in board devicetree files if they are used on the boards. Add missing I2C controllers and fix the above issues. Link: https://lore.kernel.org/u-boot/20260402171330.165754-1-jzhang918@gmail.com/ Signed-off-by: Jie Zhang <jie.zhang@analog.com>
jiez
force-pushed
the
67-i2c-nodes-missing-in-some-adsp-sc5xx-devicetrees
branch
from
65f761d to
23217f6
Compare
Done |
3 participants
sc59x processors have 6 I2C controllers, but their devicetrees currently have only 3. Add missing I2C controllers and fix the existing ones.