Merged
Conversation
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/anam/client.py">
<violation number="1" location="src/anam/client.py:613">
P0: The underlying implementation of `send_user_audio` in `StreamingClient` (which this method delegates to) contains a critical bug: it calls `self._audio_transceiver.sender.replaceTrack(...)` without awaiting it. Since `replaceTrack` is a coroutine in `aiortc`, the track replacement will never execute, and no user audio will be transmitted.
You must either:
1. Update `StreamingClient.send_user_audio` to wrap the `replaceTrack` call in `asyncio.create_task()`.
2. Or change both this method and `StreamingClient.send_user_audio` to be `async` and await the call.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
bnogas
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send_user_audio is a function that's interacted with. This should not be private and be exposed by the SDK.
This exposes this function and allows to send in audio streams directly.
Summary by cubic
Expose send_user_audio on the SDK client to let apps stream raw 16-bit PCM audio to Anam over WebRTC. Validates the connection and forwards audio to the streaming pipeline.
Written for commit 217c04f. Summary will update on new commits.