Fix: connection close sequence

[sebvanleuven]

Improving the connection close sequence, so we can call the interrupt in onClose without recursion and double calling.

---

Summary by cubic

Fix the connection close flow to prevent recursion and double notifications. Standardizes close reasons, makes teardown idempotent, speeds up WebSocket shutdown, and emits close events explicitly.

• Bug Fixes

  • Emit CONNECTION_CLOSED on client.close (NORMAL); map server SESSION_ENDED to SERVER_CLOSED; emit WEBRTC_FAILURE only on unexpected WebRTC closure; use ConnectionClosedCode everywhere.
  • Guard teardown with a _closing flag; remove ICE-based close handling; lower noisy logs to debug (ICE/data channel); use is_streaming for state checks.
  • Clear message history on close; do not send end_sequence on interrupt; mark Session as closed and signal close event before teardown for consistent state.
  • Set WebSocket close_timeout to 2s to reduce hang time on disconnects.

• New Features

  • Expose Session.send_user_audio to forward user audio directly.

^{Written for commit dd234cf. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 2 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/anam/client.py">

<violation number="1" location="src/anam/client.py:551">
P2: `interrupt()` calls the async `end_sequence()` on a possibly-None stream without awaiting it. This can raise `AttributeError` when no agent audio stream exists and also skips sending the end-of-sequence signal because the coroutine isn’t awaited. Guard for None and await the call.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

1 issue found across 3 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/anam/client.py">

<violation number="1" location="src/anam/client.py:371">
P2: close() now skips cleanup when `_is_streaming` is False, so calling close after a CONNECTION_CLOSED event leaves the streaming client and session state uncleared. This can leak resources and keep stale session info.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}