Skip to content

Fix minor issues in script.js #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix minor issues in script.js #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f2863f
Fix deprecated event shorthand
IanDelMar Dec 11, 2020
a934f2e
Remove unused declaration for `headerHeight`
IanDelMar Dec 11, 2020
5f569ef
Re-minify script
IanDelMar Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jQuery(function($) {

// Show and hide the scroll to top link based on scroll position
scrollElem.hide();
$(window).scroll(function () {
$(window).on('scroll',function () {
var scrollTop = $(document).scrollTop();
if ( scrollTop > upperLimit ) {
$(scrollElem).stop().fadeTo(300, 1); // fade back in
Expand All @@ -35,7 +35,7 @@ jQuery(function($) {
});

// Scroll to top animation on click
$(scrollElem).click(function(){
$(scrollElem).on('click',function(){
$('html, body').animate({scrollTop:0}, scrollSpeed, scrollStyle ); return false;
});

Expand All @@ -45,14 +45,13 @@ jQuery(function($) {
* *
****************************************************/

$('a[href*="#"]:not([href="#"]):not([href^="#tab"]):not([href^="#collapse"])').click(function()
$('a[href*="#"]:not([href="#"]):not([href^="#tab"]):not([href^="#collapse"])').on('click',function()
{
if (location.pathname.replace(/^\//,'') == this.pathname.replace(/^\//,'')
|| location.hostname == this.hostname)
{

var target = $(this.hash),
headerHeight = $(".primary-header").height() + 5; // Get fixed header height

target = target.length ? target : $('[name=' + this.hash.slice(1) +']');

Expand All @@ -71,4 +70,4 @@ jQuery(function($) {
* *
****************************************************/

});
});
2 changes: 1 addition & 1 deletion js/script.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.