Skip to content

feat: log when registry transport is configured insecurely #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dashtid wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

feat: log when registry transport is configured insecurely #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/image/containerd/daemon_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,7 @@ func (p *daemonImageProvider) trackSaveProgress(size int64) *daemonProvideProgre
func prepareReferenceOptions(registryOptions image.RegistryOptions) []name.Option {
var options []name.Option
if registryOptions.InsecureUseHTTP {
log.Debug("HTTP transport is enabled for registry communication")
options = append(options, name.Insecure)
}
return options
Expand Down
1 change: 1 addition & 0 deletions pkg/image/oci/registry_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ func newErrPlatformMismatch(platform *image.Platform, err error) *image.ErrPlatf
func prepareReferenceOptions(registryOptions image.RegistryOptions) []name.Option {
var options []name.Option
if registryOptions.InsecureUseHTTP {
log.Debug("HTTP transport is enabled for registry communication")
options = append(options, name.Insecure)
}
return options
Expand Down
4 changes: 4 additions & 0 deletions pkg/image/registry_options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ func (r RegistryOptions) Authenticator(registry string) authn.Authenticator {

// TLSConfig selects the tls.Config object for handling TLS authentication with a registry.
func (r RegistryOptions) TLSConfig(registry string) (*tls.Config, error) {
if r.InsecureSkipTLSVerify {
log.Debugf("TLS verification is disabled for registry %q", registry)
}

tlsOptions := r.tlsOptions(registry)

if tlsOptions == nil {
Expand Down