Added support for Europe API endpoint#12
Merged
andhapp merged 1 commit intoandhapp:masterfrom Apr 19, 2019
Merged
Conversation
Owner
|
Thanks @Richard-Degenne! I've been away for last few days. Will have a look at this today. I just noticed your comments on the other PR. For some reason, I had received no notification for it. I will go through that one as well. Thanks for your patience! |
Contributor
Author
|
Hi @andhapp, any news on the state of this PR ? |
andhapp
reviewed
Apr 18, 2019
andhapp
reviewed
Apr 18, 2019
Owner
|
Couple of minor remarks, looks good otherwise. Sorry about the long delay :-( |
Richard-Degenne
force-pushed
the
eu-endpoint
branch
from
6ce145d to
1655659
Compare
Contributor
Author
|
Hi @andhapp, No worries. I took your remarks into consideration. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Since November 2018, TextRazor added a European endpoint to its API] in order to comply with the new GDPR law. See this blog post for further details.
This PR adds support for this feature through a new configuration option.
Important note
This PR conflicts with #10. Depending on which PR gets merged first, I will need to rebase the other one and add some modifications in order to maintain consistency in the codebase.