Support for large PT buffers (>=2G) #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please create new ioctls for the 64bit variants and keep the old ones? There might be already existing users outside sptdump of the ioctl ABI/API which would be broken otherwise. Other than that the changes look good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows the use of large PT buffers. E.g., users can now configure 8GB pt buffer per- logical CPU by:
modprobe simple-pt pt_buffer_order=9 pt_num_buffers=4095
This would configure 4095 2MB output regions. We intentionally use 4095 rather than 4096 to save space on the ToPA pages (Last ToPA entry is for the END pointer)