Open
Conversation
Author
|
I've tested it extensively, and it now seems to perfectly work. |
andirady
requested changes
Aug 15, 2024
Owner
andirady
left a comment
andirady
left a comment
There was a problem hiding this comment.
Thanks for this PR. I added some comments, please have a look.
| } | ||
|
|
||
| var pomWriter = new DefaultModelWriter(); | ||
| if(addModule) { |
Owner
There was a problem hiding this comment.
Should use spaces for indentation, and add space after if. 😅
| var pomWriter = new DefaultModelWriter(); | ||
| if(addModule) { | ||
| if(standalone) { | ||
| LOG.info(() -> |
Owner
There was a problem hiding this comment.
Not sure if we need to be verbose. Maybe lower the log lever to fine?
| if(!parentPomRelativePath.endsWith(".xml")) { | ||
| parentPomRelativePath += "/pom.xml"; | ||
| } | ||
| LOG.info( |
Owner
There was a problem hiding this comment.
Maybe use fine instead of info.
| File canonicalPomParentFile = canonicalPomFile.getParentFile(); | ||
| Path canonicalPomParentPath = canonicalPomParentFile.toPath(); | ||
| Path parentPomPath = canonicalPomParentPath.resolve(parentPomRelativePath).normalize(); | ||
| LOG.info( |
Owner
There was a problem hiding this comment.
Probably should use spec.commandLine().getOut()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple implementation. I only think the standalone flag may not be correctly handled.
However, all the tests are good, so I guess it's good.