Add introspection fields during schema creation#183
Open
dwwoelfel wants to merge 1 commit intoandreas:masterfrom
Open
Add introspection fields during schema creation#183dwwoelfel wants to merge 1 commit intoandreas:masterfrom
dwwoelfel wants to merge 1 commit intoandreas:masterfrom
Conversation
andreas
reviewed
Dec 28, 2019
Owner
andreas
left a comment
andreas
left a comment
There was a problem hiding this comment.
Thanks for raising this! The patch makes sense, though I have one suggestion (see comment).
| } | ||
| in | ||
| let types = Introspection.types_of_schema schema in | ||
| Introspection.add_built_in_fields schema types |
Owner
There was a problem hiding this comment.
How about leaving add_built_in_fields as is and simply call it from here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves a problem we saw at OneGraph when upgrading to the latest version of ocaml-graphql-server.
Our query times increased by ~60ms on every query after upgrading. We tracked down the cause to this commit b187eaa, which calls
types_of_schemaon every call toexecute. We have a lot of types, so it added a noticeable amount of latency.With this change,
types_of_schemais calculated only once when you construct the schema.