Skip to content

Add 'preferDoubleQuoteAttributes' option to stringify#142

Merged
andrejewski merged 4 commits intoandrejewski:masterfrom
GriffinCodes:master
Apr 4, 2025
Merged

Add 'preferDoubleQuoteAttributes' option to stringify#142
andrejewski merged 4 commits intoandrejewski:masterfrom
GriffinCodes:master

Conversation

@GriffinCodes
Copy link
Copy Markdown
Contributor

@GriffinCodes GriffinCodes commented Apr 2, 2025

  • Concat parseDefaults and options to allow only passing in overridden values
  • Added test coverage (3 tests)
  • Added optional stringify pane to docs/index.html with checkbox for quote behavior

Let me know if there's anything I can improve 🙂

Closes #94

Copy link
Copy Markdown
Owner

@andrejewski andrejewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tiny things but looks good! Could you also post a screenshot of the updated UI?

@GriffinCodes GriffinCodes requested a review from andrejewski April 3, 2025 12:39
@GriffinCodes
Copy link
Copy Markdown
Contributor Author

GriffinCodes commented Apr 3, 2025

Thanks for the feedback! Here's the requested screenshots

image

image

Copy link
Copy Markdown
Owner

@andrejewski andrejewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! I'll get a patch release out of this out soon!

@andrejewski andrejewski merged commit 2dd04aa into andrejewski:master Apr 4, 2025
1 check failed
@andrejewski
Copy link
Copy Markdown
Owner

@GriffinCodes This change is now live in v1.1.1 on npm, thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Render attribute tags with double quotes instead of single quotes as default

2 participants