Skip to content

develop#64

Merged
andrejvysny merged 37 commits intomainfrom
develop
Feb 7, 2026
Merged

develop#64
andrejvysny merged 37 commits intomainfrom
develop

Conversation

@andrejvysny
Copy link
Copy Markdown
Owner

Pull Request

Description

Brief description of the changes made in this PR.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Security enhancement
  • Refactoring (no functional changes)
  • Test improvements
  • CI/CD improvements

Related Issues

Fixes #(issue number)
Relates to #(issue number)

Changes Made

  • Backend changes (Laravel/PHP)
  • Frontend changes (React/TypeScript)
  • Database migrations/schema changes
  • API changes
  • Configuration changes
  • Documentation updates
  • Test additions/modifications

Detailed Changes

  • Change 1: Description
  • Change 2: Description
  • Change 3: Description

Financial Domain Impact

If this PR affects financial functionality:

  • Transaction processing
  • Account management
  • Category/Tag/Merchant management
  • Bank integration (GoCardless)
  • CSV import/export
  • Financial calculations
  • Currency handling
  • Security/encryption
  • Regulatory compliance

Financial Data Accuracy

  • All monetary calculations use appropriate decimal precision
  • Currency handling is implemented correctly
  • Rounding strategies are applied consistently
  • No precision loss in financial operations

Testing

  • Tests pass locally
  • New tests have been added for new functionality
  • Manual testing completed
  • Edge cases considered and tested
  • Financial accuracy verified (if applicable)

Test Coverage

  • Unit tests
  • Feature/Integration tests
  • Browser tests (if UI changes)
  • API tests (if backend changes)

Security Considerations

  • No sensitive data exposed in logs
  • Input validation implemented
  • Authentication/authorization maintained
  • SQL injection prevention verified
  • XSS protection maintained
  • CSRF protection maintained
  • Financial data encryption verified (if applicable)

Breaking Changes

If this PR introduces breaking changes, please describe:

  • What breaks?
  • Migration path for users
  • Documentation updates needed

Screenshots/Videos

If applicable, add screenshots or videos to demonstrate the changes.

Before:
[Screenshot/Video of before state]

After:
[Screenshot/Video of after state]

Database Changes

  • Database migrations included
  • Migrations are reversible
  • Data integrity maintained
  • Performance impact considered
  • Indexes added where necessary

API Changes

If this PR modifies APIs:

  • API documentation updated
  • Backward compatibility maintained or breaking changes documented
  • Rate limiting considered
  • Error handling improved
  • OpenAPI/Swagger specs updated

Performance Impact

  • No significant performance degradation
  • Database queries optimized
  • Frontend bundle size impact minimal
  • Caching strategies implemented where beneficial
  • Memory usage optimized

Documentation

  • Code is self-documenting
  • PHPDoc blocks added/updated
  • TypeScript types properly defined
  • README updated (if needed)
  • API documentation updated (if needed)
  • User documentation updated (if needed)

Deployment Considerations

  • Environment variables documented (if new ones added)
  • Docker configuration updated (if needed)
  • Deployment scripts updated (if needed)
  • No manual intervention required for deployment
  • Rollback plan considered

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Notes

Any additional information that reviewers should know about this PR.

- Added ImportFailureDto to encapsulate details of import failures.
- Enhanced ImportFailurePersister to handle SQL failures and persist them.
- Introduced ImportFailureStatus and ImportFailureType enums for better categorization of failures.
- Created TransactionPersistenceResult to capture results of transaction persistence, including SQL failures.
- Updated TransactionPersister to utilize TransactionPersistenceResult for tracking success and failures.
- Added migration to include fingerprint and reconciled details in the transactions table.
- Optimized TransactionDataParser to generate fingerprints for transactions.
- Updated TransactionImportService to process and log SQL failures.
- Enhanced frontend components to display fingerprint information in error details.
- Documented performance optimizations for the RuleEngine.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 15, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…er with monthly statistics and transaction handling
…alculations to exclude transfers from income/expense summaries
…ing guidance for enhanced delegation in Spendly project
…for enhanced account balance management and analytics
andrejvysny and others added 8 commits February 5, 2026 18:14
… account details, and improved requisition handling
…t functionality for enhanced testing and automation
…ch + field leaking

- HeaderAnalyzerTest: processed_date detection, Slovak diacritics, UTF-8 Jaro-Winkler (7 new tests)
- TransactionDataParserTest: eu/us/simple format aliases, processed_date field (6 new tests)
- ImportCsvCommandTest: processed_date e2e, tie-break, fix pre-existing date-format bug (2 new + 2 fixed)
- HeaderAnalyzer: return best match across all fields instead of first match ≥ 0.85
- ImportCsvCommand: add currency to transactionFields, alias date→booked_date, skip unknown fields
- E2E plan: fix SK9509 delimiter from ; to ,

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…for improved environment setup

- Enhanced `compose.prod.yml` with explicit environment variables for production settings.
- Removed unnecessary `.env` file dependency and added default values for optional variables.
- Simplified Dockerfile by removing Xdebug installation and configuration, focusing on essential PHP extensions.
- Updated GitHub Actions workflow to reflect the change from `vite.config.js` to `vite.config.ts`.
- Modified `compose.prod.yml` to include build context and target for production.
- Updated Dockerfile to clarify production stage and streamline permissions setup.
- Adjusted GitHub Actions workflow to specify the production target for builds.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 7, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
3.7% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@andrejvysny andrejvysny merged commit e6e6f8a into main Feb 7, 2026
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant