Skip to content

Create a .Net Core 3 version #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andrericardo wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Create a .Net Core 3 version #1

andrericardo wants to merge 32 commits into from

Conversation

@andrericardo
Copy link
Owner

@andrericardo andrericardo commented Mar 8, 2019 •
edited
Loading

@andrericardo
Add gitignore from GitHub with OSX file
329c18a 
Source gitignore
https://github.com/github/gitignore/blob/master/VisualStudio.gitignore
@andrericardo
Set up CI with Azure Pipelines
3a2c378
@andrericardo
Update azure-pipelines.yml for Azure Pipelines
49ba9fb 
Build only AstroGrep solution
@andrericardo
Add readme explaining what this repository is
fbe2244
@andrericardo
Use .Net 4.7.2 framework
d0cdf5a
@andrericardo
Fix warning CS0618 for obsolete FormattedText
0a869bc 
Details
https://stackoverflow.com/a/40289436
https://github.com/Microsoft/WPF-Samples/tree/master/PerMonitorDPI
@andrericardo
Update packages to .Net Framework 4.7.2
939dc20
@andrericardo
Migrate from packages.config to PackageReference
42189bc 
Details:
https://docs.microsoft.com/en-us/nuget/reference/migrate-packages-config-to-package-reference
@andrericardo
Migrate projects to Visual Studio 2017 format
0635eca 
Also disabled post build events because they caused an error.
Conversion done with
https://github.com/hvanbakel/CsprojToVs2017
used command
dotnet migrate-2017 migrate AstroGrep.sln
Had to comment Microsoft.CSHARP.Targets to fix error NETSDK1005
@andrericardo
Remove not needed references
438ae50
@andrericardo
Multi-target libAstroGrep for .Net 4.7.2 and .Net Core 3.0
c9ceabe
@andrericardo
Add WinformsGUI project in .Net Core 3.0
94e1cd4 
Code builds but fails at runtime with this exception in NLog
NLog/NLog#2522

Will update NLog and check if issue persists.
@andrericardo
Upgrade NLog to 4.5.11 to fix .Net Core issue
f444bdf
@andrericardo
Add task to install .Net Core 3.0.100-preview3-010431
971e176
@andrericardo
Copy link
Owner Author

andrericardo commented Mar 10, 2019

msbuild /restore /t:rebuild /p:Configuration=Release /p:Platform="Any CPU" AstroGrep.sln works locally, don't know why it fails in Azure Pipelines with

##[error]C:\hostedtoolcache\windows\dncs\3.0.100-preview3-010431\x64\sdk\3.0.100-preview3-010431\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.TargetingPackResolution.targets(157,5): Error NETSDK1073: The FrameworkReference 'Microsoft.WindowsDesktop.App' was not recognized

😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrericardo