Fixes for julia v0.7 and v1.0#29
Merged
CarloLucibello merged 1 commit intoandrewcooke:masterfrom Sep 1, 2018
Merged
Conversation
2 similar comments
Collaborator
|
This is great, thank you! Travis is very happy so I'm gonna merge this pr. I still see some oddities in the test output, some missing newlines maybe, but this bug was alredy present before this pr and I guess we will have to live with it for the time being. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr makes it pass the tests on both versions. I don't know how well this library is maintained anymore but it is a dependency for GraphIO.jl
I realized too late that there was an open pr #27, so did not take any code from there but it might be a good idea to do that later