Removes unnecessary 5th argument of the background job#20
Open
vatson wants to merge 1 commit intoandris9:masterfrom
Open
Removes unnecessary 5th argument of the background job#20vatson wants to merge 1 commit intoandris9:masterfrom
vatson wants to merge 1 commit intoandris9:masterfrom
Conversation
…ull terminator (NUL) in the end of payload
Author
|
Any news? |
Owner
|
As the README says then this project is unmaintained. If you want to start managing it yourself then I could transfer the repo to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's done to avoid the null terminator (NUL) in the end of payload.
Without this fix, node-gearman sends the one additional argument
The 4th argument is converted to the null terminator by gearman server and concatenated with payload. It is not obvious and causes an error "SyntaxError: Unexpected token" when trying to parse JSON
With this fix, debug output returns: