Adding Android Developer Verification Sample #110

TKBurner · 2025-10-17T16:16:43Z

Add Android Developer Verification onboarding sample. Add licenses updates throughout. Update readme.md files with deprecation warnings.

…dates throughout. Update readme.md files with deprecation warnings.

gemini-code-assist · 2025-10-17T16:17:16Z

Summary of Changes

Hello @TKBurner, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new, essential Android Developer Verification Onboarding sample, providing a clear template for developers to correctly set up their projects for the Android developer verification proof of ownership process. Simultaneously, it addresses the maintenance status of older security samples by officially deprecating them and updating relevant documentation to reflect their end-of-life, ensuring users are aware of which samples are actively supported.

Highlights

New Sample Added: A new Android Developer Verification Onboarding sample has been added to guide developers through the process of signing an APK for verification, including proper file placement and folder structure.
Sample Deprecation: Several existing security samples, including BiometricAuthentication, BiometricLoginKotlin, and DirectBoot, have been marked as deprecated. They are no longer maintained and are scheduled for deletion in March 2026.
License and Documentation Updates: License headers have been updated across numerous files to reflect a 2025 copyright. Additionally, README.md files for deprecated samples now include explicit warning messages, and the main repository README.md has been restructured to highlight the new sample and the deprecation of older ones.

Ignored Files

Ignored by pattern: .github/workflows/** (1)
- .github/workflows/Build_AndroidDeveloperVerificationOnboarding.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new sample project for Android Developer Verification, which is a great addition. It also includes updates to deprecate older samples and adds license headers across various files. My review focuses on the new sample project and I've found a few issues: a critical error in an instrumented test that will cause it to fail, incorrect metadata in a packaging file, and a missed opportunity to follow best practices in the build configuration. The changes to deprecate old samples and update licenses look good.

.../src/androidTest/java/com/androiddeveloperverification/onboarding/ExampleInstrumentedTest.kt

gemini-code-assist · 2025-10-17T16:18:16Z

AndroidDeveloperVerificationOnboarding/.google/packaging.yaml

+apiRefs:
+    - android:android.hardware.fingerprint.FingerprintManager
+    - android:android.hardware.fingerprint.FingerprintManager.AuthenticationCallback
+    - android:android.hardware.fingerprint.FingerprintManager.CryptoObject
+    - android:android.security.KeyGenParameterSpec
+    - android:java.security.KeyStore
+    - android:javax.crypto.Cipher
+    - android:javax.crypto.KeyGenerator


The apiRefs listed here appear to be from a different sample related to biometrics and are not relevant to this Android Developer Verification project. This can be misleading for users trying to understand the sample's scope. Please remove this block.

gemini-code-assist · 2025-10-17T16:18:16Z

AndroidDeveloperVerificationOnboarding/app/build.gradle.kts

+
+    buildTypes {
+        release {
+            isMinifyEnabled = false


For release builds, it is a best practice to enable code shrinking and obfuscation by setting isMinifyEnabled to true. This helps in reducing the APK size and securing the code. Even for a sample project, demonstrating best practices is valuable for developers.

isMinifyEnabled = true

…a/com/androiddeveloperverification/onboarding/ExampleInstrumentedTest.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

.../src/androidTest/java/com/androiddeveloperverification/onboarding/ExampleInstrumentedTest.kt

...nOnboarding/app/src/test/java/com/androiddeveloperverification/onboarding/ExampleUnitTest.kt

cartland · 2025-10-17T18:26:02Z

.github/workflows/Build_AndroidDeveloperVerificationOnboarding.yml

+
+    - name: Make gradlew executable
+      run: chmod +x ./gradlew
+


Not now, but in a future PR, please consider configuring Spotless and then adding a required build step. This will help enforce code style and copyright headers. You can add the enforcement to this file later:

- name: Check spotless run: ./gradlew spotlessCheck

cartland

LGTM. Please consider adding Spotless in a future update, but no need to do it now.

Add Android Developer Verification onboarding sample. Add licenses up…

a36c1a3

…dates throughout. Update readme.md files with deprecation warnings.

gemini-code-assist bot reviewed Oct 17, 2025

View reviewed changes

TKBurner and others added 3 commits October 17, 2025 12:18

Update AndroidDeveloperVerificationOnboarding/app/src/androidTest/jav…

3f88e36

…a/com/androiddeveloperverification/onboarding/ExampleInstrumentedTest.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update packaging.yaml

0cf71dd

Update Build_AndroidDeveloperVerificationOnboarding.yml

6f4b07f

TKBurner self-assigned this Oct 17, 2025

florina-muntenescu approved these changes Oct 17, 2025

View reviewed changes

.../src/androidTest/java/com/androiddeveloperverification/onboarding/ExampleInstrumentedTest.kt Outdated Show resolved Hide resolved

...nOnboarding/app/src/test/java/com/androiddeveloperverification/onboarding/ExampleUnitTest.kt Outdated Show resolved Hide resolved

removed test packages

d86c19b

cartland reviewed Oct 17, 2025

View reviewed changes

cartland approved these changes Oct 17, 2025

View reviewed changes

TKBurner merged commit 13644c8 into main Oct 17, 2025
6 checks passed

TKBurner deleted the androiddeveloperverification branch October 17, 2025 18:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding Android Developer Verification Sample #110

Adding Android Developer Verification Sample #110

Uh oh!

TKBurner commented Oct 17, 2025

Uh oh!

gemini-code-assist bot commented Oct 17, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

gemini-code-assist bot Oct 17, 2025

Uh oh!

gemini-code-assist bot Oct 17, 2025

Uh oh!

Uh oh!

Uh oh!

cartland Oct 17, 2025 •

edited

Loading

Uh oh!

cartland left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Adding Android Developer Verification Sample #110

Adding Android Developer Verification Sample #110

Uh oh!

Conversation

TKBurner commented Oct 17, 2025

Uh oh!

gemini-code-assist bot commented Oct 17, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist bot Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cartland Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cartland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cartland Oct 17, 2025 •

edited

Loading