Merged
Conversation
…a3-ui-compose library
JolandaVerhoef
approved these changes
Feb 27, 2025
Contributor
JolandaVerhoef
left a comment
JolandaVerhoef
left a comment
There was a problem hiding this comment.
Some small comments, LGTM otherwise. Do look into PresentationState and how it's used in the demo, it might be a nice addition.
...eam/src/main/java/com/google/jetstream/presentation/screens/videoPlayer/VideoPlayerScreen.kt
Outdated
Show resolved
Hide resolved
...eam/src/main/java/com/google/jetstream/presentation/screens/videoPlayer/VideoPlayerScreen.kt
Outdated
Show resolved
Hide resolved
Contributor
|
/gemini summarize |
|
Warning You have reached your daily quota limit. As a reminder, free tier users are limited to 5 requests per day. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
AndroidViewcomposable in the player screen withPlayerSurfacefrommedia3-ui-composelibrary.In addition to that, this PR updates the dependencies.