-
Notifications
You must be signed in to change notification settings - Fork 595
Add MetadataState
to :ui:compose
#2700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
libraries/ui_compose/src/main/java/androidx/media3/ui/compose/state/MetadataState.kt
Outdated
Show resolved
Hide resolved
libraries/ui_compose/src/test/java/androidx/media3/ui/compose/state/MetadataStateTest.kt
Show resolved
Hide resolved
libraries/ui_compose/src/test/java/androidx/media3/ui/compose/utils/TestPlayer.kt
Outdated
Show resolved
Hide resolved
60fe964
to
944314a
Compare
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
@oceanjules I see that you have pushed the new |
@MGaetan89 yep, go for it! Although the CL in its current shape and form is still under internal scrutiny at the moment, so a I understand that this CL was not even on the original plan (GL surface type brainstorm is also happening in internally) and now it's blowing up into a whole design discussion, but please bear with us while we design maintainable and reusable Compose blocks. |
This commit introduces `MetadataState`, a Compose state that exposes metadata information about the current `MediaItem`. At the moment, it only provides the media uri.
…current media URI
f313118
to
4860dcd
Compare
Done 👍🏻
No worries, I am not in a hurry to have this merged 🙂
Thanks for the insights! I wasn't expecting this change to go through easily. This new state probably needs to have a broader purpose, rather than just exposing a URI as a shortcut. |
Ultimately it should be a single (snapshot) Player state to stop fighting the (Compose) framework for eternity. |
This commit introduces
MetadataState
, a Compose state that exposes metadata information about the currentMediaItem
. At the moment, it only provides the media uri.