Ability to pass a FactoryInstance to WaveformAudioBufferSink which will create custom WaveformBar instances #2819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a consumer app wants to override the behavior of WaveformBar it is not possible, because the creation is happening internally in WaveformAudioBufferSink.
One option is to have a override constructor for WaveformAudioBufferSink, which takes an Factory that will be responsible for creating WaveformBar.
Consumer app can pass this factory instance and create custom WaveformBar instances.
The current constructor which is present will be still available and and the current WaveformBar will be created.
There will be no impact in current behavior
Added unit test for the custom factory.