Skip to content

Conversation

SathyaTadepalli
Copy link

If a consumer app wants to override the behavior of WaveformBar it is not possible, because the creation is happening internally in WaveformAudioBufferSink.
One option is to have a override constructor for WaveformAudioBufferSink, which takes an Factory that will be responsible for creating WaveformBar.
Consumer app can pass this factory instance and create custom WaveformBar instances.
The current constructor which is present will be still available and and the current WaveformBar will be created.
There will be no impact in current behavior

Added unit test for the custom factory.

Copy link

google-cla bot commented Oct 3, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant