feat(diagnostics): line comments

[andy9a9]

• devicetree.enableWarnings -> devicetree.diagnostics.enableWarnings
  • move enableWarnings under diagnostics
• add option to exclude comments from line length diagnostics
  • this will be applied only if warnings are enabled

[mkessler001]

I added a small addon that re-analyzes open files when the settings change (e.g. line length is modified).
There is another commit marked as TODO, which comes with two test cases, which are currently failing (block comment, mistreated strings as comments).

[andy9a9]

I added a small addon that re-analyzes open files when the settings change (e.g. line length is modified).

I was thinking about the same direction, but didn't watch to add this feature. Maybe I thought in a wrong way, but once the file is formatted and you change the settings it could lead into wrong line lengths. If you add the "watching" feature just for the line length then it could be little bit inconsistent.

Overall, what's the benefit of having this feature?

[mkessler001]

I added a small addon that re-analyzes open files when the settings change (e.g. line length is modified).

I was thinking about the same direction, but didn't watch to add this feature. Maybe I thought in a wrong way, but once the file is formatted and you change the settings it could lead into wrong line lengths. If you add the "watching" feature just for the line length then it could be little bit inconsistent.

Overall, what's the benefit of having this feature?

I see a problem when users change settings. Without the update mechanism, they would need to restart VSCode (or at least reload the extensions) to apply the new settings. This is not an intuitive behavior.
I'm not sure if I understand your argument. When the file is formatted and you change the settings (e.g. reduce line length from 120 to 80), I would expect to see warnings for lines longer than 80 characters.

[mkessler001]

Looks good to me. Just keep in mind that this is a breaking change since we moved enableWarnings to diagnostics.enableWarnings.