Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things that need to be done for things to run:
[ ] Write correct MARCS format photospheres
[ ] Link things together in synthesis
[ ] Link things together in cog
[ ] Update utils for temporary directory
[ ] Replace the init to import from korg instead of moog
Things needed for correctness/consistency with MOOG
[ ] Write MOOG linelists into VALD format, with hardcoded ABO coefficients in MOOG put into Korg. (Korg MOOG format doesn't support broadening parameters or dissociation energies.)
[ ] Translate SMHR isotopes into Korg format for reading linelists
[ ] (Adam will create a new version of EW to abund that works on saturated lines)
Things needed for speed?
[ ] Replace our fitting algorithm with Korg's fitting algorithm
Things we may want
[ ] Use Korg model atmosphere grid instead of SMHR/ATLAS