Conversation
- New TranscriptionMode enum (.english / .multilingual) persisted in UserDefaults - WhisperProvider: downloads 547 MB model on demand, resamples audio to 16 kHz, runs whisper_full with Metal GPU; auto-detects language via params.language = nil (detect_language = false to avoid detection-only mode with no segments) - ParakeetProvider: add unload() to free memory on mode switch - AppState: switchTranscriptionMode(), updated preloadModel/startRecording/transcribe to dispatch to active engine; forwards isModelDownloading/modelDownloadProgress - ModelPickerView: footer popover with English Only and Multilingual rows - MenuBarView: download progress bar + percentage in header; globe icon in footer - Shortcut default changed to Option+Shift+R; display uses words (Option+, Shift+) instead of symbols - build-app.sh: embed whisper.framework with proper versioned symlink structure - sign-and-notarize.sh: sign embedded frameworks before app - justfile: DEV_CODESIGN_IDENTITY for stable dev signing (no accessibility resets) - All 35 tests pass Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new multilingual transcription mode powered by
whisper.cpp(large-v3-turbo) whilekeeping the existing fast English-only Parakeet path.
It also fixes a critical Whisper integration bug where transcriptions returned empty text even when
valid audio was recorded.
What Changed
whisper.cpp:whisper.frameworkin app packaging/signing scripts so the app launchesreliably outside local build folders
Bug Fix Included
Empty transcription with Whisper
Root cause:
whisper_fullwas called withdetect_language = true, which can trigger language-detection-onlybehavior (returns success but no segments).
Fix:
params.language = nildetect_language = falseResult:
Verification
swift buildpassesswift testpasses (35 tests)rc=0segments=1Notes