Harden workspace lifecycle validation and tmux GC safety #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyrewlee
commented
Feb 8, 2026
Owner
Author
andyrewlee
left a comment
andyrewlee
left a comment
There was a problem hiding this comment.
Devin Review found 1 potential issue.
View 11 additional findings in Devin Review.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…mments Remove dead condition in normalizeAndDedupeProjectPaths where strings.TrimSpace(path) was redundantly checked after raw (which equals strings.TrimSpace(path)) was already confirmed empty. Add clarifying comments for: read-only registry Load() skipping backup recovery, backup write-through on no-op mutations, nested lock safety in WorkspaceStore.Save, and O(n) fallback scan in findStoredWorkspace. Also fix legacy relative-repo workspace deletion scoping. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tion Resolve canonicalLookupPath against the store's metadata root instead of process CWD so lookups remain stable regardless of launch directory. Use extension-based heuristic for removed metadata children so dirs whose watch registration failed still trigger a reload. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Resolve relative paths in canonicalLookupPath against CWD (via filepath.Abs) instead of the metadata root directory. The metadata root has no relationship to where project repos live, so legacy workspaces with relative Repo/Root values were silently dropped on reload because the resolved paths never matched the registry's canonicalized entries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the change and intended behavior.
Quality Checklist
make devchecklocally.make lint-strict-newlocally for changed code.make harness-presets.go test ./internal/tmux ./internal/e2e.