Add option to use MacOS launch settings in templates#4
Draft
jacopouggeri wants to merge 1 commit intoanegostudios:mainfrom
Draft
Add option to use MacOS launch settings in templates#4jacopouggeri wants to merge 1 commit intoanegostudios:mainfrom
jacopouggeri wants to merge 1 commit intoanegostudios:mainfrom
Conversation
Member
|
oh nice, whats the issue with using the |
Author
|
Yeah the error says it doesn't find the assembly. I've tried running it multiple times from different locations but even though the dll file is clearly there, it never gets detected by dotnet. I can post the error later if needed. |
Member
|
hmm looking at this again can you try if that works for you "commandName": "Executable",
"executablePath": "dotnet",
"commandLineArgs": "VintagestoryServer.dll --tracelog --addModPath \"$(ProjectDir)/bin/$(Configuration)/Mods\"",
"workingDirectory": "$(VINTAGE_STORY)"since it uses workingDirectory it should work , at least it seems on my end from a quick test edit: "commandLineArgs": "\"$(VINTAGE_STORY)/VintagestoryServer.dll\" --tracelog --addModPath \"$(ProjectDir)/bin/$(Configuration)/Mods\"", |
Author
|
I can try later, but even when I ran dotnet directly in the terminal when being in the same folder as the assembly, it couldn't find it |
Member
|
ohh I see, that maybe an issue with the dotnet installation, On linux if you install it manually you will need to set the DOTNET_ROOT variable so it can properly locate the dotnet SDK maybe that is missing on your end? |
Author
|
I did not have DOTNET_ROOT set but it didn't seem to change things after doing so. This is the error I get when running the launch settings you posted (both variations) Again this happens even when I try to run the |
Member
|
does the dotnet command otherwise work normally? what type of mac are you using x64 (intel) or arm (M1/M2/..)? I am just trying to maybe find the source of the issue but if there is nothing we can do we can merge this. I just can not believe that that could I ask you to try to make a sample console app and see if it works there? |
Member
|
I have had another look at it and tested in my Mac OS Monterey VM and it works there without any issues |
Author
Running a console application works fine, and now that I did a fresh install of only the x64 dotnet version things sort of seem to work, so I think this issue can be closed. However I run into an issue when I try to actually run the game with the default launch settings. I think it has to do with me using a x64 version of dotnet... should I install an arm64 one instead? I could not find any guidance or information on this, why is an x64 version required in the first place if the machine is arm64? Note: this is the same issue I had when trying to run the decompiled game ;( |
Author
|
Adding to this, since the issue might have to do with the arm64 architecture, I tried running with Rosetta: This works too but the screen renders at 1/4th of the size while the mouse input is correct (as if it was full-size) |
Author
|
Might be worth reopening since I do think the issue persists for arm64 macs |
chore: keep only changes relevant to PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are few, but there are some, modders on Mac OS. Since I found out the ideal launch settings for Mac OS, something I struggled with a lot when I had just started, it would be nice to make these available for everyone by default.