Skip to content

refactor(prompts): alphabetize list options #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kingcody wants to merge 1 commit into from
Closed

refactor(prompts): alphabetize list options #1133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 30 additions & 36 deletions app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,13 @@ var AngularFullstackGenerator = yeoman.generators.Base.extend({
this.prompt([{
type: 'list',
name: 'script',
default: 1,
message: 'What would you like to write scripts with?',
choices: [ 'JavaScript', 'CoffeeScript'],
choices: ['CoffeeScript', 'JavaScript'],
filter: function( val ) {
var filterMap = {
'JavaScript': 'js',
'CoffeeScript': 'coffee'
'CoffeeScript': 'coffee',
'JavaScript': 'js'
Copy link
Member

@Awk34 Awk34 Aug 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a point to alphabetical sorting? I think it makes more sense to have JS first at least.

};

return filterMap[val];
Expand All @@ -116,16 +117,16 @@ var AngularFullstackGenerator = yeoman.generators.Base.extend({
}, {
type: 'list',
name: 'stylesheet',
default: 1,
default: 2,
message: 'What would you like to write stylesheets with?',
choices: [ 'CSS', 'Sass', 'Stylus', 'Less'],
choices: ['CSS', 'Less', 'Sass', 'Stylus'],
filter: function( val ) { return val.toLowerCase(); }
}, {
type: 'list',
name: 'router',
default: 1,
message: 'What Angular router would you like to use?',
choices: [ 'ngRoute', 'uiRouter'],
choices: ['ngRoute', 'uiRouter'],
filter: function( val ) { return val.toLowerCase(); }
}, {
type: 'confirm',
Expand Down Expand Up @@ -163,23 +164,20 @@ var AngularFullstackGenerator = yeoman.generators.Base.extend({
type: 'checkbox',
name: 'odms',
message: 'What would you like to use for data modeling?',
choices: [
{
value: 'mongoose',
name: 'Mongoose (MongoDB)',
checked: true
},
{
value: 'sequelize',
name: 'Sequelize (MySQL, SQLite, MariaDB, PostgreSQL)',
checked: false
}
]
choices: [{
value: 'mongoose',
name: 'Mongoose (MongoDB)',
checked: true
}, {
value: 'sequelize',
name: 'Sequelize (MySQL, SQLite, MariaDB, PostgreSQL)',
checked: false
}]
}, {
type: 'list',
name: 'models',
message: 'What would you like to use for the default models?',
choices: [ 'Mongoose', 'Sequelize' ],
choices: ['Mongoose', 'Sequelize'],
filter: function( val ) {
return val.toLowerCase();
},
Expand All @@ -200,23 +198,19 @@ var AngularFullstackGenerator = yeoman.generators.Base.extend({
when: function (answers) {
return answers.auth;
},
choices: [
{
value: 'googleAuth',
name: 'Google',
checked: false
},
{
value: 'facebookAuth',
name: 'Facebook',
checked: false
},
{
value: 'twitterAuth',
name: 'Twitter',
checked: false
}
]
choices: [{
value: 'facebookAuth',
name: 'Facebook',
checked: false
}, {
value: 'googleAuth',
name: 'Google',
checked: false
}, {
value: 'twitterAuth',
name: 'Twitter',
checked: false
}]
}, {
type: 'confirm',
name: 'socketio',
Expand Down