Skip to content

test: use node:assert in basic and build E2E tests #30764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Jul 22, 2025

Replaces error throwing with Node.js assertions in E2E tests. This provides more informative error messages when tests fail.

@clydin clydin added the target: minor This PR is targeted for the next minor release label Jul 22, 2025
@clydin clydin force-pushed the e2e/assert-update-1 branch 2 times, most recently from bd63c83 to c6d8f2e Compare July 22, 2025 17:28
Replaces error throwing with Node.js assertions in E2E tests.
This provides more informative error messages when tests fail.
@clydin clydin force-pushed the e2e/assert-update-1 branch from c6d8f2e to 42f5a34 Compare July 22, 2025 18:35
@clydin clydin marked this pull request as ready for review July 22, 2025 18:51
@clydin clydin requested a review from alan-agius4 July 22, 2025 18:51
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 22, 2025
@clydin clydin force-pushed the e2e/assert-update-1 branch from bd5964b to f6ac20e Compare July 22, 2025 19:30
Replaces error throwing with Node.js assertions in E2E tests.
This provides more informative error messages when tests fail.
@clydin clydin force-pushed the e2e/assert-update-1 branch from f6ac20e to 0db3626 Compare July 22, 2025 19:48
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 24, 2025
@clydin clydin merged commit abe9dac into angular:main Jul 24, 2025
31 checks passed
@clydin clydin deleted the e2e/assert-update-1 branch July 24, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants