Skip to content

test(@angular/build): add unit tests for unit-test builder options #30766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Jul 22, 2025

Adds a suite of disabled unit tests for the options of the unit-test builder. These tests cover the functionality of each option and will be enabled in a future commit.

Adds a suite of disabled unit tests for the options of the unit-test builder.
These tests cover the functionality of each option and will be enabled in a future commit.
@clydin clydin added the target: minor This PR is targeted for the next minor release label Jul 22, 2025
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 23, 2025
} from '../setup';

describeBuilder(execute, UNIT_TEST_BUILDER_INFO, (harness) => {
xdescribe('Option: "browsers"', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pending() worked here without failing the test suite? IIRC that's what I used for the disabled tests for the karma-on-application-builder feature.

@clydin clydin merged commit c70dae4 into angular:main Jul 24, 2025
101 of 105 checks passed
@clydin clydin deleted the unit-test/option-tests branch July 24, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: @angular/build target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants