Skip to content

fix(material/core): remove letter-spacing from the Material typography classes #31890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(material/core): remove letter-spacing from the Material typography classes #31890

wants to merge 1 commit into from

Conversation

andrewseguin
Copy link
Contributor

They are generally about 0rem and add little impact with extra complexity

@andrewseguin andrewseguin requested a review from a team as a code owner September 17, 2025 18:52
@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Sep 17, 2025
@andrewseguin andrewseguin requested review from crisbeto and ok7sai and removed request for a team September 17, 2025 18:52
mmalerba
mmalerba reviewed Sep 26, 2025
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this odd though? the token still exists and still affects other typography styles, just not these classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalerba mmalerba mmalerba left review comments

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto is a code owner automatically assigned from angular/components-googlers

@ok7sai ok7sai Awaiting requested review from ok7sai ok7sai is a code owner automatically assigned from angular/components-googlers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: material/core target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewseguin @mmalerba