Fix Widget changed layer_id panic when undocking tabs (debug builds)#318
Open
mcthesw wants to merge 1 commit intoanhosh:mainfrom
Open
Fix Widget changed layer_id panic when undocking tabs (debug builds)#318mcthesw wants to merge 1 commit intoanhosh:mainfrom
mcthesw wants to merge 1 commit intoanhosh:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The tab body Ui was constructed with an ID that didn't include the surface:
When a tab is moved to a floating window surface, both the main dock (Background layer) and the window (Middle layer) can render a tab body with the same ID in the same frame. egui's debug assertion then fires because it sees the same widget ID appearing in two different layers.
Fix
Scope the tab body ID by surface:
This preserves the original property that tab IDs remain stable when a tab is moved between nodes on the same surface, while ensuring tabs on different surfaces get distinct IDs.
closes #317