Fix two issues: missing query parameter, and incorrect line breaker handling#20
Open
DanielYWoo wants to merge 2 commits intoanismiles:masterfrom
DanielYWoo:master
Open
Fix two issues: missing query parameter, and incorrect line breaker handling#20DanielYWoo wants to merge 2 commits intoanismiles:masterfrom DanielYWoo:master
DanielYWoo wants to merge 2 commits intoanismiles:masterfrom
DanielYWoo:master
Conversation
DanielYWoo
commented
Aug 15, 2013
DanielYWoo
commented
- raw query is missing when handshake, it's common add some query parameters in the web socket url.
- if the message contains line breakers, they are escaped which causes runtime exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.