Skip to content

fix:Pull to Refresh is disabled when hasMore is flipped to false #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix:Pull to Refresh is disabled when hasMore is flipped to false #284

wants to merge 1 commit into from

Conversation

zhou2912169
Copy link

fix:Pull to Refresh is disabled when hasMore is flipped to false

danutdumitru1977
danutdumitru1977 reviewed Oct 27, 2021
View reviewed changes
Copy link

@danutdumitru1977 danutdumitru1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution is correct -> the problem was the missing update of lastScrollTop after the bottom was reached, so it remains 2000 let's say, and because of this onStart exited on first line, and isDragging was always on false, so no more pull down to refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@danutdumitru1977 danutdumitru1977 danutdumitru1977 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhou2912169 @danutdumitru1977