feat: add support for non-app dir as Workspace root dir#3
Open
Abadulrehman wants to merge 3 commits intoankush:developfrom
Open
feat: add support for non-app dir as Workspace root dir#3Abadulrehman wants to merge 3 commits intoankush:developfrom
Abadulrehman wants to merge 3 commits intoankush:developfrom
Conversation
Author
|
@ankush Have a look and see what you think. This works very well for my use-case now. |
|
@ankush - is there any chance of this being merged in? 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A potential solution for #2. Introduces a new setting,
workspaceRoot, which can be one of [single-app, apps, bench], with "single-app" being the default and resulting in no change in the behavior.Selecting one of the other settings takes them into account when forming the path of the test.