Open
Conversation
Owner
|
Thanks @eteixido1 . Could you replace the bin files by the ones in openfang ? We already have getimage and mosquito and external binaries are not necessary! |
Scripts with /usr/bin path for the existing binaries
Author
|
I already deleted this bin files and changed the paths in scripts. Be careful with common_functions line 93 there was an error with yellow led. |
Owner
|
@eteixido1 Thanks a lot. I saw that you also have a file named "fs/opt/bin/busybox", we also have that on openfang rootfs. |
Author
|
Sorry, I didn't found it. If you want I can correct it and pull it again.
…On Thu, Sep 19, 2019, 02:10 André Pedro ***@***.***> wrote:
@eteixido1 <https://github.com/eteixido1> Thanks a lot. I saw that you
also have a file named "fs/opt/bin/busybox", we also have that on openfang
rootfs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42?email_source=notifications&email_token=AMUC4XQAARPQLRDAWVGJUDTQKK7QHA5CNFSM4IUQIKWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7BZYSA#issuecomment-532913224>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMUC4XRNLRFH7FEIT4LSW6LQKK7QHANCNFSM4IUQIKWA>
.
|
Owner
|
@eteixido1 Could you test that MQTT is working well with these changes ? |
anmaped
requested changes
Feb 10, 2020
Owner
anmaped
left a comment
anmaped
left a comment
There was a problem hiding this comment.
Could you remove the busybox binary ? I would like to merge the pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.