ignore command nesting in deploy rulebook#519
Closed
cmbtgl wants to merge 1 commit intoannetutil:mainfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently most of deploy rulebooks have a logic that commands from patch is not nested.
For example, huawei.deploy have dialogs for
local-usercommands on global level while in real deploy they is executed underaaablock.Current logic works fine because there is no dialogs defined for
aaacommand in rulebook. But, if you add dialogs foraaacommand to rulebook then all current global rules stops to match, because they have different depth. And to fix this rulebook should be changed fromto something like this
to work properly. And newline between commands from different levels is a must to parse rulebook properly.
This PR makes deploy rulebook to ignore nesting and match commands in any block level.