Support session_factory arg for BaseNetboxClient#65
Merged
Conversation
azryve
force-pushed
the
feature/client-sync-session-factory
branch
from
7a81b19 to
d1745e7
Compare
azryve
changed the title
The size of different options in BaseNetboxClient is growing. Instead of passing down every single possible option its better to provide a factory.
azryve
force-pushed
the
feature/client-sync-session-factory
branch
from
d1745e7 to
3312c79
Compare
The format fix is too ugly imo:
ssl_context: SSLContext | None = None,
- session_factory: Callable[[ClientSession], ClientSession] | None = None,
+ session_factory: Callable[[ClientSession], ClientSession]
+ | None = None,
azryve
changed the title
Tishka17
approved these changes
Oct 27, 2025
Tishka17
reviewed
Oct 27, 2025
| @@ -1,4 +1,4 @@ | |||
| line-length = 79 | |||
| line-length = 80 | |||
Collaborator
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The size of different options in BaseNetboxClient is growing.
Instead of passing down every single possible option its better to provide a factory.
Passing internal session instance to a callable allows to: