Skip to content

fix: return cmd error in case enable fails #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gescheit merged 1 commit into from
Apr 13, 2026
Merged

fix: return cmd error in case enable fails #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/device/cisco/ciscoios.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ var autoCommands = []cmd.Cmd{
cmd.NewCmd("terminal monitor disable", cmd.WithErrorIgnore()), // ios xr
cmd.NewCmd("terminal length 0", cmd.WithErrorIgnore()),
cmd.NewCmd("terminal width 0", cmd.WithErrorIgnore()),
cmd.NewCmd("enable", cmd.WithErrorIgnore(), cmd.WithAddAnswers(cmd.NewAnswerWithNL("Password: ", ""))),
// force 10 attempts to get cmd error instead of QuestionExceptionRepeated
cmd.NewCmd("enable", cmd.WithErrorIgnore(), cmd.WithAddAnswers(cmd.NewAnswerWithNLMaxAttempts("Password: ", "", 10))),
}

func NewDevice(connector streamer.Connector, opts ...genericcli.GenericDeviceOption) genericcli.GenericDevice {
Expand Down
Loading