feat(provider): add POST callback and id_token handling for OAuth2#245
Merged
thdxr merged 3 commits intoanomalyco:masterfrom Apr 9, 2025
aryasaatvik:apple-auth-postform
Merged
feat(provider): add POST callback and id_token handling for OAuth2#245thdxr merged 3 commits intoanomalyco:masterfrom aryasaatvik:apple-auth-postform
thdxr merged 3 commits intoanomalyco:masterfrom
aryasaatvik:apple-auth-postform
Conversation
- Add form_post response_mode support for Apple Sign In - Implement POST callback route in OAuth2 provider - Add ID token verification using JWKS endpoint - Refactor callback logic to reduce duplication - Extract and expose decoded ID token claims This change enables Apple Sign In with name and email scopes which requires form_post response mode and proper handling of the ID token.
|
- Include JWKS endpoint for Google provider to support ID token verification.
aryasaatvik
commented
Apr 4, 2025
| endpoint: { | ||
| authorization: "https://accounts.google.com/o/oauth2/v2/auth", | ||
| token: "https://oauth2.googleapis.com/token", | ||
| jwks: "https://www.googleapis.com/oauth2/v3/certs", |
Contributor
Author
There was a problem hiding this comment.
google also returns an id token. this allows decoding it in tokenset
Contributor
Author
|
probably should just be using oidc instead of adding id token support in oauth. but apple auth support is broken in both oauth and oidc.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #82
This change enables Apple Sign In with name and email scopes which requires form_post response mode and proper handling of the ID token.