fix: prevent prompt crash when opening new session with existing prompt #7764
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Found a potential related PR: PR #4878: "Fixed: prompt now preserved when creating new session" This PR appears to address a very similar issue - preserving prompt text when creating a new session. While it's an older PR, it deals with the same core functionality that PR #7764 is fixing (preventing crashes and preserving prompt text during session transitions). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7541
fixed this fatal error when creating a new session would crash if you had prompt in the textarea.
prompt component in home.tsx is not defined onMount yet, now it handles the timing better and keeps your prompt text (tested with
ctrl+x n) when moving to a new session. when selecting new session from the dialog the text is not always preserved.note: #7702 fixes switched sessions & forks. this fix is for new sessions
before:
before.fix.mov
after:
after.fix.mov